fix: Allow multiple podSpec overrides to target the same TargetJob #2880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @astefanutti PTAL! Thanks! 😊 |
kaisoz
changed the title
kaisoz
force-pushed
the
2871-allow-podspecoverride-dupl-jobs
branch
from
097f58e to
10da76b
Compare
Pull Request Test Coverage Report for Build 18312702644Details
💛 - Coveralls |
kaisoz
force-pushed
the
2871-allow-podspecoverride-dupl-jobs
branch
from
10da76b to
4d2a9cf
Compare
astefanutti
reviewed
Oct 7, 2025
|
nit about title, I wouldn't call it "duplicated targetJobs", it sounds like allowing a bug. "fix: Allow multiple podSpec overrides to target the same TargetJob" wdyt? |
kaisoz
changed the title
kaisoz
force-pushed
the
2871-allow-podspecoverride-dupl-jobs
branch
from
4d2a9cf to
f9487ea
Compare
andreyvelich
reviewed
Oct 7, 2025
kaisoz
force-pushed
the
2871-allow-podspecoverride-dupl-jobs
branch
from
f9487ea to
b7505ba
Compare
astefanutti
reviewed
Oct 7, 2025
astefanutti
reviewed
Oct 7, 2025
Signed-off-by: Tomas Tormo <tomas.tormo@gmail.com>
kaisoz
force-pushed
the
2871-allow-podspecoverride-dupl-jobs
branch
from
b7505ba to
1843634
Compare
|
/lgtm Thanks @kaisoz! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, it's forbidden to create a TrainJob that include PodSpecOverrides with duplicated targetJobs. This breaks the Kueue integration when there are user-provided podSpecOverrides because it injects its configuration using this API
This PR fixes this by removing such limitation
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2871
Checklist: